-
Notifications
You must be signed in to change notification settings - Fork 1
Comments on wheel building script #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I think you actively don't want the pandas checkout to go into the host operating system, because you want the checkout to be a temporary copy that you will throw away with the building image. The `--no-deps` flag avoids copying dependencies into the wheelhouse, such as numpy.
Hi Matthew, thanks for looking. I've been tinkering with it a bit more in #2 and was able to get Travis to build and run the tests in a container without timing out. Would you be open to those uploading to wheels.scipy.org at the end of the build similar to https://github.com/MacPython/numpy-wheels? And then we can upload those to PyPI for each release? |
Sure - no problem - I'll add the encrypted key to this PR. |
Which repo will this be building from - TomAugspurger/pandas-manylinux ? |
Ahh, I think I'll do it from |
Whoops, I don't have permission to create a new repo under pydata. @jreback I'm guessing you do? I think it make sense to have this live there, right? Could you make a blank |
https://github.com/pydata/pandas-manylinux should be good |
This should upload the wheels when build triggered on that repo (and only that repo).
Sorry to be a bit NIH - but I was working on a scripting system for combined OSX / Manylinux wheels over at https://github.com/matthew-brett/multibuild - and it turned out to be pretty easy to update the current Pandas wheel-building repo to build 64- and 32-bit manylinux wheels :
There are some 32-bit test failures (see pandas-dev/pandas#13566), but the 64-bit wheels test OK, and are now up at http://wheels.scipy.org/ . See also updated info at https://github.com/MacPython/pandas-wheels . Would you consider uploading these? Numpy / scipy / Cython already have Manylinux wheels, matplotlib and h5py wheels are imminent. Automated upload instructions at https://github.com/MacPython/pandas-wheels#uploading-the-built-wheels-to-pypi . |
Saw your post yesterday on the manylinux ML, you beat me to it :) Thanks for solving this in a general way. I think Jeff has the permissions to upload to PyPI. |
@jreback - anything I can do to help here? Should I move the discussion over the pandas mailing list or issues? |
@jreback - should I email the Pandas list? Or open a Pandas issue about this? |
@matthew-brett @jreback We'd very much appreciate if Pandas wheels can appear on PyPi. It's slowing down our test suites significantly to have to rebuild from source each time. |
@matthew-brett I just saw your comment. what is the difference between m & mu? (need both)?
|
ok they are all uploaded. |
|
Great - thanks for uploading them. Please let me know if there's anything I can do to help with the next release. I think that it should be as simple as the instructions at https://github.com/macpython/pandas-wheels#triggering-a-build |
Thank you very much!
|
I think you actively don't want the pandas checkout to go into the host operating system, because you want the checkout to be a temporary copy that you will throw away with the building image.
The
--no-deps
flag avoids copying dependencies into the wheelhouse, such as numpy.