Skip to content

feat: support dataloader with multiple inputs #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 8, 2021
Merged

feat: support dataloader with multiple inputs #76

merged 14 commits into from
Jun 8, 2021

Conversation

xuyxu
Copy link
Member

@xuyxu xuyxu commented Jun 3, 2021 •
edited
Loading

resolves #75

Steps

  • code: make existing ensembles adapt to multiple inputs using non-keyword arguments
  • test: add unit tests on the multiple inputs case for all ensembles

xuyxu
xuyxu commented Jun 8, 2021
View reviewed changes
Copy link
Member Author

@xuyxu xuyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

xuyxu
xuyxu commented Jun 8, 2021
View reviewed changes
Copy link
Member Author

@xuyxu xuyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xuyxu xuyxu merged commit 50de90f into master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataLoader with multiple inputs caused errors
1 participant
@xuyxu