Skip to content

unmet peer graphql-subscriptions@^2.0.0: found 3.0.0 #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasir-barati opened this issue Dec 10, 2024 · 4 comments · Fixed by #330
Closed

unmet peer graphql-subscriptions@^2.0.0: found 3.0.0 #327

kasir-barati opened this issue Dec 10, 2024 · 4 comments · Fixed by #330
Labels
bug Something isn't working

Comments

@kasir-barati
Copy link
Contributor

Describe the bug
So it is not really a bug but can become one since graphql-subscriptions have changed their API since version 3.x.

https://github.com/apollographql/graphql-subscriptions/blob/master/CHANGELOG.md#300

asyncIterator is no longer available, instead asyncIterableIterator is the one that should be used.

Have you read the Contributing Guidelines?

Yep

To Reproduce
Steps to reproduce the behavior:

  1. Create a new NestJS project
  2.  pnpm add @ptc-org/nestjs-query-core @ptc-org/nestjs-query-graphql @ptc-org/nestjs-query-typeorm @nestjs/typeorm @nestjs/common @nestjs/graphql graphql graphql-subscriptions class-transformer class-validator dataloader typeorm

Then you can see this warning:

 WARN  Issues with peer dependencies found
.
└─┬ @ptc-org/nestjs-query-graphql 7.1.0
  └── ✕ unmet peer graphql-subscriptions@^2.0.0: found 3.0.0

Expected behavior
No warning

Screenshots
image

Desktop (please complete the following information):

  • Node Version: 22.12.0
  • Nestjs-query Version: 7.1.0

Additional context

I am currently working with this monorepo project inside a bigger repo: https://github.com/kasir-barati/nestjs-materials/tree/main/typeorm

@kasir-barati kasir-barati added the bug Something isn't working label Dec 10, 2024
@TriPSs
Copy link
Owner

TriPSs commented Dec 10, 2024

Thanks, would you be willing to create a PR?

@kasir-barati
Copy link
Contributor Author

kasir-barati commented Dec 10, 2024

Yeah sure. Why not. BTW thanks for this wonderful work. It is really good that this lib is still kicking.

@kasir-barati
Copy link
Contributor Author

@TriPSs I am not familiar with the release plan, do yo think you can tell me how usually new releases are published on npm, if we have a doc for I'd love to take a look.

@TriPSs
Copy link
Owner

TriPSs commented Dec 12, 2024

Useally I realse when there is something to release, now I did all the dependa bot things and went for food and forgot it 😅, let me release this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants