add input filter for umem_cache bufctl stacks #8
Conversation
|
|
||
| UmemStreamReader.prototype.onLine = function (line) | ||
| { | ||
| /* The first two lines are always ignored. */ |
There was a problem hiding this comment.
Are there actually two lines ignored in addition to the two lines you're ignoring with each stack?
There was a problem hiding this comment.
right so there is a 2 line header for the file in general, and then each sample has a 2 line header
|
I'm pretty torn about whether it would be worthwhile to commonize some of this code with the code for the DTrace reader. Obviously a fair bit overlaps, but it's intertwined with a bunch of code that's legitimately different. You could extract a few utility functions for stripping function and template arguments and the like, but the complexity (and obfuscation) of an abstract base class to manage the overall control flow may not be worth saving the few LOC involved. Could you document (even if just in a comment here) what inputs you tested, ideally with some example frames? I may one day refactor the code and it will be useful to have sample input to regression test against. Thanks for the feature! |
No description provided.