-
Notifications
You must be signed in to change notification settings - Fork 9
[Merged by Bors] - CompatHelper: bump compat for Setfield to 1, (keep existing compat) #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
github-actions
wants to merge
5
commits into
main
from
compathelper/new_version/2022-05-24-00-15-37-441-04181554448
Closed
[Merged by Bors] - CompatHelper: bump compat for Setfield to 1, (keep existing compat) #67
github-actions
wants to merge
5
commits into
main
from
compathelper/new_version/2022-05-24-00-15-37-441-04181554448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5bd12a4
to
d198ff4
Compare
…xisting compat) (#68) Co-authored-by: CompatHelper Julia <[email protected]>
bors try |
Seems some dependency holds it back. |
Seems to be JuliaFolds/BangBang.jl#229. |
yebai
approved these changes
Nov 6, 2022
bors r+ |
Merge conflict. |
yebai
approved these changes
Nov 7, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
) This pull request changes the compat entry for the `Setfield` package from `0.7.1, 0.8` to `0.7.1, 0.8, 1`. This keeps the compat entries for earlier versions. Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: David Widmann <[email protected]> Co-authored-by: Hong Ge <[email protected]>
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Setfield
package from0.7.1, 0.8
to0.7.1, 0.8, 1
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.