-
Notifications
You must be signed in to change notification settings - Fork 38
Simplified README #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified README #261
Conversation
@yebai or @devmotion happy with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe one could also add a link to the docs in the text, but I think it's fine with the badge(s) as well.
README.md
Outdated
@@ -1,484 +1,13 @@ | |||
# Bijectors.jl | |||
|
|||
[](https://turinglang.github.io/Bijectors.jl/stable) | |||
[](https://turinglang.github.io/Bijectors.jl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe keep a link to the latest release (stable) and the latest (possibly unreleased) commit (dev)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately stable
docs doesn't exist 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT the problem is that TagBot.yml contains a bug - the action does not have sufficient permissions to trigger other Github actions, and hence docs won't be built when a new tag/release is made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to fix this and then we could point to stable docs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not finding any stable docs 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was a new release created after the TagBot PR was merged? I think only then a stable docs build should be triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaah, gotcha. Aight, I'll add it to the README then.
Co-authored-by: David Widmann <[email protected]>
Done:) |
Good to go now @devmotion ? |
Thanks man! |
The current README is from a time before we had documentation for Bijectors.jl. Now that we do, I think we should just simplify the it, and defer everything to the documentation.