Skip to content

Simplified README #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2023
Merged

Simplified README #261

merged 5 commits into from
Jun 5, 2023

Conversation

torfjelde
Copy link
Member

The current README is from a time before we had documentation for Bijectors.jl. Now that we do, I think we should just simplify the it, and defer everything to the documentation.

@torfjelde torfjelde mentioned this pull request Jun 3, 2023
@torfjelde
Copy link
Member Author

@yebai or @devmotion happy with this?

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe one could also add a link to the docs in the text, but I think it's fine with the badge(s) as well.

README.md Outdated
@@ -1,484 +1,13 @@
# Bijectors.jl

[![Stable](https://img.shields.io/badge/docs-stable-blue.svg)](https://turinglang.github.io/Bijectors.jl/stable)
[![Latest](https://img.shields.io/badge/docs-latest-blue.svg)](https://turinglang.github.io/Bijectors.jl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep a link to the latest release (stable) and the latest (possibly unreleased) commit (dev)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately stable docs doesn't exist 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT the problem is that TagBot.yml contains a bug - the action does not have sufficient permissions to trigger other Github actions, and hence docs won't be built when a new tag/release is made.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to fix this and then we could point to stable docs as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not finding any stable docs 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a new release created after the TagBot PR was merged? I think only then a stable docs build should be triggered.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah, gotcha. Aight, I'll add it to the README then.

@torfjelde
Copy link
Member Author

Done:)

@devmotion devmotion mentioned this pull request Jun 5, 2023
@torfjelde torfjelde reopened this Jun 5, 2023
@torfjelde
Copy link
Member Author

Good to go now @devmotion ?

@torfjelde
Copy link
Member Author

Thanks man!

@torfjelde torfjelde merged commit 88d9c66 into master Jun 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the torfjelde/readme-update branch June 5, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants