Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely removes intermediate storage (solving #37) and makes changes to the callback system to be compatible with this change. The main points are:
CallbackTrigger
e.g.PostPredictCallback
. These can be added by the user if they have a special time they want to callback. It's a bit of a pain that these need default implementations that do nothing—this is also quite annoying in that it fails silently if you get the type signature wrong in your callback definition as it just runs the default that does nothing. There's probably a cleaner way to do this but I think this is fine for this PRThe only issue this introduces is that it makes the guided filter a bit harder to implement since the old log weights are "forgotten" by the time we get to the
update
step. There are definitely a few options of how to handle this so not too worried for now—just a case of finding the most elegant.Let me know if @charlesknipp @FredericWantiez have any thoughts otherwise I will merge soonish so you guys can build on this modified interface.