Require Julia 1.3 #1378
Merged
Require Julia 1.3 #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail due to the error fixed in #1377. |
yebai
approved these changes
Aug 17, 2020
|
There seems to be a problem with Julia 1.5 on Windows 32bit. There is no clear error message though, and tests seem to be fine with Julia 1.3 on Windows 32bit, so it might be a problem upstream or in some other package. Should we disable tests on Windows 32bit completely? Or just with Julia 1.5? |
|
It’s helpful to test Win32 on at least one Julia release. It allows us to spot syntactical and numerical errors for some algorithms, e.g. HMC. |
|
Wouldn't it be sufficient to test on Linux 32bit to spot numerical errors? It seems we can test both Julia versions there. |
|
Yes, that's enough. I did not realise we are testing 32 bit on Linux. |
|
All remaining test errors are due to #1377. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support of Julia < 1.3 since other packages such as Tracker and NNlib only support Julia >= 1.3 which would require us to backport fixes if we want to support Julia < 1.3 properly.