Skip to content

add inverse_sqrt lr decay style #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 28, 2022

Conversation

NouamaneTazi
Copy link
Collaborator

@NouamaneTazi NouamaneTazi commented Nov 22, 2022

adds support for inverse square decay style
P.S: ignores min-lr param for now

To use it just add these flags to your command:

--lr-decay-style=inverse_sqrt --lr-warmup-style=linear/constant

image

@NouamaneTazi NouamaneTazi marked this pull request as ready for review November 22, 2022 21:56
Copy link
Collaborator

@thomasw21 thomasw21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You may want to also add the normalized version as well depending on what was used for PaLM for example.

@thomasw21
Copy link
Collaborator

thomasw21 commented Nov 23, 2022

Oh I don't have write access to this repo. You'll have to ask someone that does. cc @spyysalo

Co-authored-by: thomasw21 <[email protected]>
Copy link
Collaborator

@thomasw21 thomasw21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@NouamaneTazi NouamaneTazi merged commit 5e811b6 into TurkuNLP:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants