feat: Ariakit comments #1448
Merged
feat: Ariakit comments #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewlipski
added a commit
that referenced
this pull request
Feb 20, 2025
* Added ShadCN comments implementation * Removed unneeded state * Fixed menu stealing focus * Updated screenshots * Added ariakit comments implementation (#1448)
matthewlipski
added a commit
that referenced
this pull request
Feb 28, 2025
* wip: better liveblocks support * misc fixes * misc * revert minimal * simplify setup * update config * fix * fix * markview * cleanup * wip * wip * wip * wip * misc * add threadstore tests * document recommended auth rules * resolve * basic userstore impl * user auth * Big comments UX WIP * Updated reactions UX * change reaction implementation * reactions improvements * small cleanup * cleanups + mark some todos * comments * fix locales * fix build * cleanup + sample * fix build * fix lint * disable liveblocks for now * lint * fix linkify warning + make toggle editable comment * fix content reset bug * Implemented PR feedback * fix placeholder * clean comment editor * fix build * fix placeholders * - Adjusted comment spacing - Changed emoji icon - Changed "More actions" dropdown alignment - Made toolbar button tooltips with spaces not become multi-line - Made "More actions" and emoji buttons hide tooltips when dropdown is open - Made emoji picker close when emoji is picked * Implemented PR feedback * fix build * implement TipTapThreadStore * address feedback * add comment * wip * add autofocus * Simplified tooltip + popover interaction * feat: ShadCN comments (#1445) * Added ShadCN comments implementation * Removed unneeded state * Fixed menu stealing focus * Updated screenshots * Added ariakit comments implementation (#1448) * change reaction auth * make emoji optional * fix bug * Extracted reaction badge WIP * fix useUsers * Fixed formatting toolbar not showing up when editor is non-editable * Fixed reaction badge tooltip line breaks and made leaving comment not hide popovers/menus in it * Improved badge UX and made reactions hide when editing * Fixed new comments sometimes not being selectable * remove unused files * rest thread store * fix copy/paste * add shift * add docs * update docs * revert liveblocks, will be separate PR * clean lockfile * fix some todos * adress number of comments * address more comments * address some comments * clean commentsplugin * ForceSelectionVisible * fix floatingcomposercontroller * fix unit test * close threads on esc * remove debugger * small fix * Fixed badge styles on docs * Fixed badge click handler * Added remaining UX fixes from Mantine to Ariakit/ShadCN * Externalized strings * Small styling fix * Small styling fix * Fix lint * Fixed side menu regression issue * Implemented PR feedback * Implemented PR feedback * Updated emoji picker screenshots * Revert "Updated emoji picker screenshots" This reverts commit a647ec3. * Updated `package-lock.json` * Fixed `no` locale * Updated `package-lock.json` * Added temp test pass --------- Co-authored-by: matthewlipski <[email protected]> Co-authored-by: Matthew Lipski <[email protected]>
matthewlipski
added a commit
that referenced
this pull request
Mar 19, 2025
* wip: better liveblocks support * misc fixes * misc * revert minimal * simplify setup * update config * fix * fix * markview * cleanup * wip * wip * wip * wip * misc * add threadstore tests * document recommended auth rules * resolve * basic userstore impl * user auth * Big comments UX WIP * Updated reactions UX * change reaction implementation * reactions improvements * small cleanup * cleanups + mark some todos * comments * fix locales * fix build * cleanup + sample * fix build * fix lint * disable liveblocks for now * lint * fix linkify warning + make toggle editable comment * fix content reset bug * Implemented PR feedback * fix placeholder * clean comment editor * fix build * fix placeholders * - Adjusted comment spacing - Changed emoji icon - Changed "More actions" dropdown alignment - Made toolbar button tooltips with spaces not become multi-line - Made "More actions" and emoji buttons hide tooltips when dropdown is open - Made emoji picker close when emoji is picked * Implemented PR feedback * fix build * implement TipTapThreadStore * address feedback * add comment * wip * add autofocus * Simplified tooltip + popover interaction * wip * feat: ShadCN comments (#1445) * Added ShadCN comments implementation * Removed unneeded state * Fixed menu stealing focus * Updated screenshots * Added ariakit comments implementation (#1448) * change reaction auth * make emoji optional * fix bug * Extracted reaction badge WIP * fix useUsers * Fixed formatting toolbar not showing up when editor is non-editable * Fixed reaction badge tooltip line breaks and made leaving comment not hide popovers/menus in it * Improved badge UX and made reactions hide when editing * wip * refactor: add renderEditor boolean to BlockNoteView * Fixed new comments sometimes not being selectable * fix unnecessary rerender * remove unused files * Improved UX/UI * rest thread store * fix copy/paste * add shift * add docs * update docs * revert liveblocks, will be separate PR * clean lockfile * fix some todos * adress number of comments * address more comments * address some comments * clean commentsplugin * ForceSelectionVisible * fix floatingcomposercontroller * fix unit test * close threads on esc * remove debugger * small fix * Fixed badge styles on docs * Fixed badge click handler * Added remaining UX fixes from Mantine to Ariakit/ShadCN * Externalized strings * Small styling fix * Small styling fix * Fix lint * Fixed side menu regression issue * Implemented PR feedback * Implemented PR feedback * Updated emoji picker screenshots * Revert "Updated emoji picker screenshots" This reverts commit a647ec3. * Updated `package-lock.json` * Fixed `no` locale * Updated `package-lock.json` * Added temp test pass * Fixed merge issues * Fixed issues and build * Separated open and resolved comments * Small fixes * BlockNoteView changes and major UX improvements * Small user select change * - Renamed `ThreadStreamView` to `ThreadsSidebar` - Added filtering and sorting options - Polished comments demo UX * Small cleanup * Fix build and cleanup * `BlockNoteView` fix * WIP feedback TODOs * WIP feedback * Small fix * Small fix * WIP feedback * WIP feedback * WIP feedback * WIP feedback * Shrunk emoji picker * Fixed build * Fixed lint * Small styling fix * Fixed docs build * Updated `Thread` and `Comment` props + small changes * Implemented PR feedback * Updated demo styles * Added file name extensions to examples * Added docs & minor changes * Fixed i18n * Styling changes * Fixed lint/build * improve commentplugin state * clean threadssidebar and fix performance * Implemented PR feedback * Moved styles * Reverted doc ID * Resolved remaining feedback * Small fix * Fixed TODOs * Small fix * Implemented remaining TODO * Implemented PR feedback * Small examples update * Small styling fix --------- Co-authored-by: yousefed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Ariakit implementation of comment components.