refactor: add renderEditor boolean to BlockNoteView #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
reviewed
Feb 21, 2025
Comment on lines
191
to
198
| {!editor.headless && ( | ||
| <> | ||
| <Portals contentComponent={portalManager} /> | ||
| {doRenderEditor ? ( | ||
| <BlockNoteViewEditor>{children}</BlockNoteViewEditor> | ||
| ) : ( | ||
| children | ||
| )} |
There was a problem hiding this comment.
This sort of brings to mind what the difference is between this renderEditor={false} and headless being true on the editor. Can this be combined?
There was a problem hiding this comment.
thanks, see update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the BlockNoteView code a bit and adds support for
renderEditor={false}The idea is that the consumer can then "position" (render) the editor themselves, but still access the Context values that BlockNoteView is setting up.
Example usage on a different branch:
BlockNote/examples/07-collaboration/04-comments/App.tsx
Line 150 in 42cdbd1