fix: Comments feedback & flaky test #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
reviewed
Mar 4, 2025
| @@ -5,7 +5,7 @@ | |||
| "scripts": { | |||
| "build": "tsc", | |||
| "lint": "eslint src --max-warnings 0", | |||
| "playwright": "npx playwright test", | |||
| "playwright": "npx playwright test --ui", | |||
There was a problem hiding this comment.
Probably not intentional
There was a problem hiding this comment.
It is actually! Since we really only use this command to check why an individual test is failing, I figured we may as well add the --ui flag to make this easier. I would previously set --headed instead, but --ui is much nicer.
There was a problem hiding this comment.
Alright, well then the playwright:ui task is redudant then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the remaining feedback from #1376
Also fixes an e2e test that was temporarily bypassed because it was flaky