fix: Removed @emoji-mart/react dependency
#1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
reviewed
Mar 4, 2025
| @@ -0,0 +1,23 @@ | |||
| // From https://github.com/missive/emoji-mart/blob/main/packages/emoji-mart-react/react.tsx | |||
| import React, { useEffect, useRef } from "react"; | |||
| import { Picker } from "emoji-mart"; | |||
There was a problem hiding this comment.
Does this include the whole bundle of emoji mart data? Or is that separate?
Do we need this as a dynamic import?
There was a problem hiding this comment.
Don't think so, iirc from doing manual testing the emojis are fetched on initial render. Diving into the source code seems to support this:
The _init gets called in the Picker component's componentWillReceiveProps function, so either way it's not until the first render.
There was a problem hiding this comment.
Alright, cool, wasn't aware of how it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@emoji-mart/reactis not compatible with React 19 and is only one file, so this PR changes it from a dependency to just a copy of the file