Skip to content

fix: dispatch suggestion menu as a separate transaction #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

nperez0111
Copy link
Contributor

Dispatching in the same transaction that modified content could cause positions to be different because of appendedTransactions (e.g. Unique-id plugin)
So, this changes to only dispatch the menu in a separate transaction so that there will likely not be any other content modifications by a meta only dispatch

Dispatching in the same transaction that modified content could cause positions to be different because of appendedTransactions (e.g. Unique-id plugin)
So, this changes to only dispatch the menu in a separate transaction so that there will likely not be any other content modifications by a meta only dispatch
Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Apr 17, 2025 2:49pm
blocknote-website ❌ Failed (Inspect) Apr 17, 2025 2:49pm

Copy link

pkg-pr-new bot commented Apr 17, 2025

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@1614

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@1614

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@1614

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@1614

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@1614

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@1614

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@1614

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@1614

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@1614

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@1614

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@1614

commit: 685a859

@nperez0111 nperez0111 merged commit 9a3f03a into main Apr 17, 2025
6 of 8 checks passed
@nperez0111 nperez0111 deleted the suggestion-menu-fix branch April 17, 2025 14:41
Copy link

sentry-io bot commented Apr 22, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ InvalidStateError: Failed to execute 'send' on 'WebSocket': Still in CONNECTING state. /examples/collaboration/comments View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant