GH-11: Adjusted the lookup to the latest VS Code.

 - [win32]: Use `which` when cannot find Git on the `$PATH`.
 - Listen on the process' `close` instead of `exit`.
 - Moved the Windows build to Travis.
 - Pinned the versions with `yarn.lock`.
 - Bumped up the dependencies.
 - New version -> `0.0.2`.

Closes #11.

Co-authored-by: Alex Tugarev <[email protected]>
Co-authored-by: Akos Kitta <[email protected]>

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

.gitignore

@@ -1,4 +1,5 @@
 .DS_Store
 node_modules
 lib
-*.log
+*.log
+package-lock.json

.travis.yml

@@ -1,13 +1,17 @@
 language: node_js
 
+env:
+  # Fix Windows build never ending in Travis CI
+  # https://travis-ci.community/t/timeout-after-build-finished-and-succeeded/1336
+  - YARN_GPG=no
+
 os:
   - linux
   - osx
+  - windows
 
 node_js:
-- '8'
-- '7'
-- '6'
+- 10
 
 git:
   depth: 1
@@ -17,7 +21,7 @@ branches:
   - master
 
 install:
-  - npm i
+  - yarn
 
 script:
-  - npm run build && npm run test
+  - yarn build && yarn test

README.md

@@ -1,22 +1,22 @@
 # find-git-exec
 [![Build Status](https://travis-ci.org/TypeFox/find-git-exec.svg?branch=master)](https://travis-ci.org/TypeFox/find-git-exec)
-[![Build status](https://ci.appveyor.com/api/projects/status/8x9w27df2bit7jan/branch/master?svg=true)](https://ci.appveyor.com/project/kittaakos/find-git-exec/branch/master)
 
 A lightweight library for locating the Git executable on the host system.
+This library is a stripped down version of the Git discovery logic [implemented and used by VS Code](https://github.com/microsoft/vscode/blob/master/extensions/git/src/git.ts#L50-L141).
 
 ## Install
 ```bash
-npm i -S find-git-exec
+yarn add find-git-exec
 ```
 
 ## Build
 ```bash
-npm run build
+yarn build
 ```
 
 ## Test
 ```bash
-npm run test
+yarn test
 ```
 
 ## Example

appveyor.yml

@@ -1,3 +1,3 @@
 --require ts-node/register
 --reporter spec
---watch-extensions ts
+--watch-extensions ts

mocha.opts

@@ -1,10 +1,13 @@
 {
   "name": "find-git-exec",
-  "version": "0.0.1-alpha.2",
+  "version": "0.0.2",
   "description": "A lightweight library for locating the Git executable on the host system",
   "keywords": [
     "git"
   ],
+  "engines": {
+    "node": ">=10.11.0 <12"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/TypeFox/find-git-exec.git"
@@ -27,17 +30,19 @@
   "author": "typefox <[email protected]>",
   "license": "MIT",
   "dependencies": {
-    "@types/node": "^8.0.26"
+    "@types/node": "^10.14.22",
+    "@types/which": "^1.3.2",
+    "which": "^2.0.1"
   },
   "devDependencies": {
-    "@types/chai": "^4.0.4",
-    "@types/mocha": "^2.2.42",
-    "chai": "^4.1.2",
-    "mocha": "^3.5.0",
-    "rimraf": "^2.6.1",
-    "ts-node": "^3.3.0",
-    "tslint": "^5.7.0",
-    "tslint-no-unused-expression-chai": "0.0.2",
-    "typescript": "^2.5.2"
+    "@types/chai": "^4.2.4",
+    "@types/mocha": "^5.2.7",
+    "chai": "^4.2.0",
+    "mocha": "^6.2.2",
+    "rimraf": "^3.0.0",
+    "ts-node": "^8.4.1",
+    "tslint": "^6.0.0-beta0",
+    "tslint-no-unused-expression-chai": "^0.1.4",
+    "typescript": "^3.1.3"
   }
 }

package.json

@@ -5,16 +5,27 @@
 
 import * as fs from 'fs';
 import { expect } from 'chai';
-import findGit from './find-git-exec';
+import findGit, { Git } from './find-git-exec';
 
 describe('find-git-exec', async () => {
 
-    it('find', async () => {
-        const git = await findGit();
+    it('find', async function () {
+        this.timeout(60_000);
+        const git = await findGit({ hint: undefined, onLookup: (p: string) => console.log(`[TRACE]: Git discovery: ${p}`) });
         const { path, version, execPath } = git;
-        expect(fs.existsSync(path)).to.be.true;
-        expect(fs.existsSync(execPath)).to.be.true;
-        expect(version.startsWith('2')).to.be.true;
+        expect(fs.existsSync(path), `[path]: expected ${path} to exist on the filesystem`).to.be.true;
+        expect(fs.existsSync(execPath), `[execPath]: expected ${execPath} to exist on the filesystem`).to.be.true;
+        expect(version.startsWith('2'), `[version]: expected version 2.x was ${version} instead`).to.be.true;
+        const promises: Array<Promise<Git>> = [];
+        for (let i = 0; i < 1000; i++) {
+            promises.push(findGit({ hint: undefined, onLookup: (p: string) => {/* silent */ } }));
+        }
+        const results = await Promise.all(promises);
+        results.forEach(({ version: actualVersion, path: actualPath, execPath: actualExecPath }) => {
+            expect(actualVersion).to.be.deep.equal(version, `Expected ${version} as 'version', got ${actualPath} instead.`);
+            expect(actualPath).to.be.deep.equal(path, `Expected ${path} as 'path', got ${actualPath} instead.`);
+            expect(actualExecPath).to.be.deep.equal(execPath, `Expected ${path} as 'execPath', got ${actualPath} instead.`);
+        })
     });
 
 });