Could not find Git on the PATH - not recognized on windows

[fernfab]

Message: "Could not find Git on the PATH"

OS - Windows 10 Pro

Git binaries on path:
C:\Users<user>\AppData\Local\Programs\Git\bin

Using git Bash:
which
/mingw64/bin/git

[kittaakos]

Thanks for logging, @fernfab! Please confirm, does the Git feature work out of the box in VS Code?

[mcgordonite]

I see a similar problem when git can only be found on the PATH, e.g. when extracting the portable distribution of git for Windows somewhere on disk and adding it to the PATH.

In that case, the path returned from find-git-exec is just the string "git", rather than an absolute path as in all other cases. It stems from this line: https://github.com/TypeFox/find-git-exec/blob/master/src/find-git-exec.ts#L111.

VS Code git integration works fine for me with this set up.

You could use where.exe to convert it to an absolute path in this case, but I don't know if that's available before Windows 10.

[kittaakos]

Thank you for help, @mcgordonite.

VS Code git integration works fine for me with this set up.

I am going to fix the issue and release a new version in the next days. Please bear with me.

[kittaakos]

For the record; I am going to add a dependency to which and do exactly what VS Code does.

[kittaakos]

@mcgordonite, can you please help to verify my changes? I have created a PR with the proposed fix: #12
Can you please try the following steps from a Git bash?

rm -rf ./find-git-exec/ \
&& git clone --single-branch -b GH-11 https://github.com/TypeFox/find-git-exec.git \
&& yarn --cwd ./find-git-exec \
&& yarn --cwd ./find-git-exec build \
&& yarn --cwd ./find-git-exec test

Verifying it from a PowerShell and/or a CMD.EXE would be a great help too 😊Once you have cloned and built from a Git Bash, it would be sufficient to run yarn test from the other shells. Thank you!