Implement dispose method on WebSocketMessageReader. #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-vanderheijden
requested review from
CGNonofr and
kaisalmen
as code owners
ethan-vanderheijden
force-pushed
the
implement-dispose-method
branch
from
0af5d2d to
ba5a140
Compare
kaisalmen
approved these changes
Feb 14, 2024
|
Sorry, can you do a new release of |
|
@ethan-vanderheijden yes, good point. I wanted to put out the next release when everything else is ready, but #600 is not yet done. A new version should be there end of the day. |
|
@ethan-vanderheijden https://www.npmjs.com/package/vscode-ws-jsonrpc/v/3.2.0 is now available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
dispose()according to the spec:https://github.com/microsoft/vscode-languageserver-node/blob/21f4f0af6bf1623483c3e65f36e550bfdb6245a6/jsonrpc/src/common/messageReader.ts#L48
Although the
listen()method returns a disposable callback, it seems like it's not used. Instead, thedispose()method is called on the reader (see here).Without implementing the dispose method, you can stop the language client, but calling
languageClient.start()will not restart it properly.