Skip to content

Update ntypescript to 2016-09-30 release #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Update ntypescript to 2016-09-30 release #1073

merged 1 commit into from
Oct 11, 2016

Conversation

guncha
Copy link
Contributor

@guncha guncha commented Sep 22, 2016

  • All compiled assets are included (atom packages are git tags and hence the built files need to be a part of the source control)

This just updates the ntypescript version to the latest available to get access to some recent Typescript goodies. Due to all Atom plugins running in a restricted environment and and a recent change in Typescript, it's now necessary to require("typescript") via a loophole (https://github.com/atom/loophole) package provided by the Atom team.

The change causing the issue: https://github.com/Microsoft/TypeScript/pull/9580/files#diff-f620fed640223a55bf6a5c9ceb2e100fR19

@guncha
Copy link
Contributor Author

guncha commented Sep 30, 2016

Due to a recent Typescript PR (microsoft/TypeScript#11265) the loophole hack is no longer necessary! 🎉

We should still update the Typescript version, though. I'm mainly interested in literal token, number and boolean types.

@guncha
Copy link
Contributor Author

guncha commented Oct 9, 2016

Since Typescript no longer requires the loophole hack, I removed it from this PR and updated the ntypescript again. That's the only real change. The rest in the generated output are due to changes in how Typescript emits string (double quotes, yay!) and calls to super. Should be 100% backwards compatible.

If it makes sense to you, @basarat, could you please merge?

EDIT: Oh, I guess I updated the auto-generated grammar, too. Seems to be an improvement for regular Typescript since it now correctly highlights generator functions, for example, but I seem to have broken the .tsx support so I'll look into that.

@guncha guncha changed the title Update ntypescript to 2016-09-06 release Update ntypescript to 2016-09-30 release Oct 9, 2016
@basarat
Copy link
Member

basarat commented Oct 10, 2016

@guncha I've added you to the atom-typescript-collaborators team so you should be able to merge / deploy at your will 🌹

@guncha
Copy link
Contributor Author

guncha commented Oct 10, 2016

Thank you, I appreciate the trust. I'll try to look into the other PRs, too.

@guncha guncha merged commit 5138a8a into TypeStrong:master Oct 11, 2016
@guncha guncha deleted the update-ntypescript branch October 11, 2016 01:05
@nycdotnet
Copy link
Contributor

way to go, @guncha !

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants