Hide fileStatus when compileOnSave is false

[wmaurer]

Fixes issue #524

Hope it looks okay. I'm pulling the compileOnSave directly from the cache.

[basarat]

getOrCreateProject is something that shouldn't be called from the front end code. We have a seperate nodejs process running the background managing projects / language service etc. More docs : https://github.com/TypeStrong/atom-typescript/blob/master/CONTRIBUTING.md#architecture

[wmaurer]

Ok thanks, that's clearer to me now. Is calling parent.getProjectFileDetails the correct approach?

[basarat]

Is calling parent.getProjectFileDetails the correct approach?

Yes 👍 However I would prefer you track down usages of updateFileStatus. I suspect they already have access to the projectFileDetails. Look at

atom-typescript/lib/main/atom/onSaveHandler.ts

Line 33 in 9a76801

if (fileDetails.project.compileOnSave

Maybe add a function like hideEmitStatus there 🌹

[wmaurer]

Unfortunately, not all other usages of updateFileStatus have immediate access to projectFileDetails, e.g.:

atom-typescript/lib/main/atomts.ts

Line 126 in 2a7b563

mainPanelView.panelView.updateFileStatus(filePath);

(in this case I could move the updateFileStatus up into the then on line 111)

And here I would have to fetch projectFileDetails, as it's not already called:

atom-typescript/lib/main/atom/commands/commands.ts

Line 120 in 2a7b563

panelView.updateFileStatus(filePath);

It seems to me to be a bit anti-DRY to have logic and code calling a hideEmitStatus wherever we currently call updateFileStatus (6 places at the moment), but I can do it if you like ...

Another idea would be to react to changes to the compileOnSave flag, and hide/show the emit status based on that. The updateFileStatus logic would still run for every file, but whether it's hidden or shown would be project-wide.

Let me know what you think.

[basarat]

It will be in the next release 🌹

[wmaurer]

Thanks!