fix(eslint): don't lint ignored files #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter out files ignored by the eslint config when linting on watched builds. Before this, ignored files would still be passed to the linter when changed and would trigger warnings in webpack. Closes TypeStrong#485
|
Code Climate has analyzed commit 6f76ae1 and detected 0 issues on this pull request. View more on Code Climate. |
piotr-oles
approved these changes
Jul 31, 2020
|
Thanks a lot for this fix! :) |
|
🎉 This PR is included in version 5.0.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out files ignored by the eslint config when linting on watched builds. This happened already for initial and non-watched builds.
This should stop the warnings every time a file ignored by eslintrc is changed that look like
Closes #485