Fix generateTrace with newer TypeScript versions and build: false
#730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update README.md to better reflect the current state of this feature.
mkantor
force-pushed
the
revitalize-generate-trace
branch
from
66948d7 to
777ee59
Compare
piotr-oles
reviewed
Apr 10, 2022
As per code review feedback, do not bother testing intermediate TypeScript versions.
mkantor
force-pushed
the
revitalize-generate-trace
branch
from
777ee59 to
97a9f40
Compare
|
@piotr-oles I addressed your feedback; thanks for the quick review. Let me know if you have any other suggestions. |
|
🎉 This PR is included in version 7.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #722 and also fixes another issue I noticed along the way:
generateTracedid not work unless I was usingbuild: true(I think that was introduced by #691).Adds tests and updates documentation.