Skip to content

update: adding documentation for PR-2906 #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 10, 2024

Conversation

NoelStephensUnity
Copy link
Contributor

@NoelStephensUnity NoelStephensUnity commented Apr 30, 2024

For NGO v1.10.0 and v2.0.0-exp.3

Adding documentation for PR-2906:
Unity-Technologies/com.unity.netcode.gameobjects#2906

WARNING: Please make your PR against the develop branch.


Select the type of change:

  • Small Changes - Typos, formatting, slight revisions
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site and Docusaurus

Purpose of the Pull Request:
Adding some documentation on new NetworkBehaviour methods.

Issue Number:
MTT-8470

Vic-Cooper and others added 6 commits April 5, 2024 15:12
Co-authored-by: Rémi MACH <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: LagowiecDev <[email protected]>
Co-authored-by: amanda-butler-unity <[email protected]>
Co-authored-by: Noel Stephens <[email protected]>
Co-authored-by: Griffin of Innatical <[email protected]>
Co-authored-by: Christopher Pope <[email protected]>
Co-authored-by: Steve Diniro <[email protected]>
Co-authored-by: s-omeilia-unity <[email protected]>
Co-authored-by: Alex Martin <[email protected]>
Co-authored-by: Monaxys <[email protected]>
Co-authored-by: Flap27 <[email protected]>
Co-authored-by: NRTnarathip <[email protected]>
@unity-cla-assistant
Copy link

unity-cla-assistant commented Apr 30, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@jabbacakes jabbacakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left some comments on the new content. Gonna have a read through of the linked PR and see if there's any additional info I think needs adding.

@jabbacakes
Copy link
Collaborator

@NoelStephensUnity That review ended up taking a bit longer than usual. Tl;dr, I've split the NetworkBehaviour page out into two: one for spawning and despawning, and one for synchronizing and serialization. Having it all on one page was getting to be a lot.

Lemme know what you think.

@NoelStephensUnity
Copy link
Contributor Author

@NoelStephensUnity That review ended up taking a bit longer than usual. Tl;dr, I've split the NetworkBehaviour page out into two: one for spawning and despawning, and one for synchronizing and serialization. Having it all on one page was getting to be a lot.

Lemme know what you think.

I like it! 👍

@jabbacakes jabbacakes merged commit 60fcd87 into develop Jun 10, 2024
1 check passed
@jabbacakes jabbacakes deleted the update/adding-documentation-for-pr-2906 branch June 10, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants