Skip to content

fix: in-scene networkobject with networktransform synchronization when parented under gameobject (up-port of 2895) [MTT-8402] #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 25, 2024
Merged

fix: in-scene networkobject with networktransform synchronization when parented under gameobject (up-port of 2895) [MTT-8402] #2898

merged 12 commits into from
Apr 25, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Apr 25, 2024 •
edited
Loading

An upwards port to v2.0.x for the #2895 fix.

Fixing issue where parenting synchronization was not properly handling the scenario where a NetworkObject is parented under a GameObject (with or without auto object parent sync enabled).

MTT-8402
[GH-2888] Network Tran

Changelog

  • Fixed: Issue where an in-scene placed NetworkObject with NetworkTransform that is also parented under a GameObject would not properly synchronize when the parent GameObject had a world space position other than 0,0,0.

Testing and Documentation

  • Includes integration test (InScenePlacedNetworkObjectTests.ParentedInSceneObjectUnderGameObject).
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
07f31eb 
Fixing issue where parenting synchronization on the authority side was not properly handling the scenario where a NetworkObject is parented under a GameObject (with or without auto object parent sync enabled).
@NoelStephensUnity
fix
f63c030 
Fixing issue where parenting synchronization on the non-authority side was not properly handling the scenario where a NetworkObject is parented under a GameObject (with or without auto object parent sync enabled).
@NoelStephensUnity
update
0c87445 
migrate when to apply in local space above the parenting check.
@NoelStephensUnity
test
0732a70 
Adding an integration test to validate an in-scene placed NetworkObject's initial synchronization when parented under a GameObject. This also test both scenarios where the in-scene placed NetworkObject does and does not have a NetworkTransform.
@NoelStephensUnity
fix
18b773d 
removing white space after added enabled field during a cherry pick merge.
@NoelStephensUnity
style
88d42e1 
removing unused using directive.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner April 25, 2024 19:12
@NoelStephensUnity NoelStephensUnity mentioned this pull request Apr 25, 2024
Merged
@NoelStephensUnity
update
45315f4 
updating some package versions
@NoelStephensUnity
update
e2c8ddd 
updating the version of linux used
@NoelStephensUnity
Update CODEOWNERS
43eaf9c 
just catching up the CODEOWNERS v2.0 develop branch to changes in v1.0 branch
@NoelStephensUnity
Merge branch 'develop-2.0.0' into fix/in-scene-with-nt-and-parented-u…
fe130d0 
…nder-gameobject-up-port-2895
@NoelStephensUnity NoelStephensUnity merged commit b449ea8 into develop-2.0.0 Apr 25, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/in-scene-with-nt-and-parented-under-gameobject-up-port-2895 branch April 25, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NoelStephensUnity