fix: client side disconnect incorrect client count on host-server side [MTTB-135] #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| peerClientIds[idx] = peerId; | ||
| ++idx; | ||
| if (peerClientIds.Length > idx) |
There was a problem hiding this comment.
This assures if the server has not timed out prior to the client synchronizing that it doesn't exceed the allocated peer count.
fluong6
approved these changes
Jun 3, 2024
NoelStephensUnity
deleted the
fix/client-side-disconnect-incorrect-client-count-host-server-side
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue with the client count not being correct on the host or server side when a client disconnects itself from a session.
This also resolves the issue with the host trying to send itself a message that it has connected when first starting up.
MTTB-135
fix: #2927
Changelog
Testing and Documentation