Skip to content

fix: adding null checks when accessing NetworkBehaviour #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix: adding null checks when accessing NetworkBehaviour #3011

merged 2 commits into from
Aug 19, 2024

Conversation

fluong6
Copy link
Collaborator

@fluong6 fluong6 commented Aug 15, 2024

Preventing invalid read and write operations when m_NetworkBehaviour is not in a valid state.

Changelog

  • Fixed issue by adding null checks in NetworkVariableBase.CanClientRead and NetworkVariableBase.CanClientWrite methods to ensure safe access to NetworkBehaviour.

Testing and Documentation

  • No tests have been added.

@fluong6 fluong6 requested a review from a team as a code owner August 15, 2024 21:03
NoelStephensUnity
NoelStephensUnity approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluong6 fluong6 merged commit beb08e8 into develop Aug 19, 2024
24 checks passed
@fluong6 fluong6 deleted the fix/can-client-null-safety branch August 19, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluong6 @NoelStephensUnity