Skip to content

fix: prevent exception when showing despawned NetworkObject - up port of #3029 #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Aug 25, 2024

Up-port of #3029

This resolves an issue where a NetworkObject component could be despawned or its GameObject destroyed in the same frame prior to attempting to show it.

MTTB-377

fix: #3023

Changelog

  • Fixed: Issue where the NetworkSpawnManager.HandleNetworkObjectShow could throw an exception if one of the NetworkObject components to show was destroyed during the same frame.

Testing and Documentation

  • Includes integration test NetworkVisibilityTests.HideShowAndDeleteTest.
  • No documentation changes or additions were necessary.

up-port of #3029
up-port test of #3029 while also taking into consideration the two network topologies.
Adding changelog entry.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review August 25, 2024 17:48
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner August 25, 2024 17:48
@NoelStephensUnity NoelStephensUnity merged commit 40f84dc into develop-2.0.0 Aug 26, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/prevent-exception-when-showing-despawned-object-up-port branch August 26, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant