Skip to content

fix: player prefab null exception when using prefab hash via connection approval #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2024
Merged

fix: player prefab null exception when using prefab hash via connection approval #3042

merged 5 commits into from
Sep 6, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Sep 3, 2024 •
edited
Loading

This PR resolves the issue where if you do not have a player prefab assigned but do have prefab hash provided in the connection approval process it would cause and exception to be thrown (due to the lack of the player prefab assignment).
(needs to be backported to v1.x)

fix: #3032

Changelog

  • Fixed: Issue where setting a prefab hash value during connection approval but not having a player prefab assigned could cause an exception when spawning a player.

Testing and Documentation

  • Includes integration test updates to ConnectionApproval.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
ddfefc3 
fixing the issue where setting the prefab hash but not assigning a player prefab would cause an exception.
@NoelStephensUnity
update
4656354 
change log entry
@NoelStephensUnity
test
fa322fe 
Updating the ConnectionApproval test to include spawning from player prefab, prefab hash, spawning no player, and failing validation.
@NoelStephensUnity
update
a178bac 
updating changelog with PR number.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review September 3, 2024 15:25
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner September 3, 2024 15:25
NoelStephensUnity added a commit that referenced this pull request Sep 5, 2024
@NoelStephensUnity
fix
e739268 
back port of #3042 fix
@NoelStephensUnity NoelStephensUnity mentioned this pull request Sep 5, 2024
Merged
NoelStephensUnity added a commit that referenced this pull request Sep 6, 2024
@NoelStephensUnity
fix: player prefab null exception when using prefabhash connection ap…
f41fb30 
…proval (backport-3042) (#3046)

* fix

back port of #3042 fix

* test

Test updates to validate the fix.

* update

adding changelog entry
@NoelStephensUnity NoelStephensUnity merged commit c0cd658 into develop-2.0.0 Sep 6, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/player-prefab-null-exception-when-using-prefabhash-connection-approval branch September 6, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluong6 fluong6 fluong6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @fluong6