fix: Add size validation to named and unnamed message sending #3043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larus
changed the title
fluong6
reviewed
Sep 5, 2024
com.unity.netcode.gameobjects/Runtime/Messaging/NetworkMessageManager.cs
Show resolved
Hide resolved
NoelStephensUnity
approved these changes
Sep 5, 2024
NoelStephensUnity
added a commit
that referenced
this pull request
Sep 6, 2024
NoelStephensUnity
added a commit
that referenced
this pull request
Sep 6, 2024
NoelStephensUnity
deleted the
fix/add-size-validation-to-namedmessage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size validation added to the 4 entry points for Named/Unnamed message functions, where there is context to have more descriptive error messages as oppose to the generic serialisation messages you'll get when deeper in the call stack.
A few more details are also added to other places for better errors in generic message sending, like the TryBeginWrite check where the batch message header might push the message over the limit but you'd get a stange "Attempted to write without first calling TryBeginWrite()" later on.
MTTB-378
fix: #2363
Changelog
Testing and Documentation