Skip to content

fix: NetworkVariable LastUpdateSent client timing #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NoelStephensUnity
Copy link
Collaborator

Fixing a possible scenario where a client could have a NetworkVariableBase.LastUpdateSent value that was incorrect. This just uses the synchronized ServerTime to assure the LastUpdateSent is always less than the current ServerTime.

Changelog

  • Fixed: Issue where clients could have a wrong time delta on NetworkVariableBase which could prevent from sending delta state updates.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

Use server time for NetworkVariableBase.LastUpdateSent time deltas when connected to a service or when not the server.
Adding changelog entry
adding PR number to entry.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review September 4, 2024 23:51
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner September 4, 2024 23:51
@NoelStephensUnity NoelStephensUnity changed the title fix: NetworkBariable LastUpdateSent client timing fix: NetworkVariable LastUpdateSent client timing Sep 5, 2024
@NoelStephensUnity NoelStephensUnity merged commit 4b58d28 into develop-2.0.0 Sep 8, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networkvariable-lasttimesent-client-timing branch September 8, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant