Skip to content

fix: NetworkTransport early and post late updates #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 6, 2024
Merged

fix: NetworkTransport early and post late updates #3113

merged 24 commits into from
Nov 6, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 31, 2024 •
edited
Loading

This PR improves upon UnityTransport's oder of operation when it comes to:

  • Processing new connections at the beginning of the frame.
    • This used to happen within the update stage.
  • Process transport events before NetworkBehaviour updates but after NetworkTimeSystem has been updated for the current frame.
    • This used to happen within the update stage.
  • Flush send queued outbound messages at the end of the frame.
    • This used to happen on next frame and within the update stage.

Changelog

  • Fixed: If you update multiple packages, create a new section with a new header for the other package.

Testing and Documentation

  • Includes updates to UnityTransportTests.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
97adb46 
Break out the UnityTransport's Update method into two methods: EarlyUpdate and PostLateUpdate.
@NoelStephensUnity
update
c0d2cbf 
Modifications to NetworkManager to invoke the newly adding EarlyUpdate and PostLateUpdate methods.
@NoelStephensUnity
update
85e7b2b 
Adjusting the job handle name.
Migrating the m_FlushSendJobHandle.Complete(); outside of the driver IsCreated check to avoid any potential job safety issues.
@NoelStephensUnity
style
4360933 
removing unused Update method and removing the Unity.Netcode.Transports.UTP namespace reference.
@NoelStephensUnity
update
6a37df6 
Removing the job handle stuff as that could potentially break users trying to get RTT during OnGUI.
@NoelStephensUnity
test fix
8b8930e 
Adjusting the UnityTransport tests to simulate the NetworkManager invoking the EarlyUpdate and PostLateUpdate methods.

Adding event processing in shutdown primarily for integration testing to handle any pending events prior to shutting down the transport.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 31, 2024 22:02
@NoelStephensUnity NoelStephensUnity requested review from a team as code owners October 31, 2024 22:02
@NoelStephensUnity
test - fix
dbcd40b 
This resolves the issue with the UnitTransportConnectionTests failing in areas where it was just waiting and not invoking the EarlyUpdate and PostLateUpdate methods.
@NoelStephensUnity
test - fix
a73cfa7 
Another pass trying to fix what seems to be a possible timing issue.
@NoelStephensUnity
test - fix
dca0e12 
Approaching the issue differently by adding a UnityTransportTestComponent that registers with the playerloop update stages needed to properly handle message processing.
@NoelStephensUnity
test
0defa5b 
Removing the unused additional script and namespace reference.
@NoelStephensUnity
test
8f2f089 
removing some more unused code and the namespace reference.
@NoelStephensUnity
style
12c8bf4 
removing some CRs and unused local var.
@NoelStephensUnity
test - fix
da91e02 
Removing whitespace issue.
Setting velocity to zero after moving and after waiting.
@NoelStephensUnity
update
a61547c 
Splitting up accepting a connection and process event.
Migrating process event into the PreUpdate but after time has updated.
@NoelStephensUnity
Test
e07e538 
Minor test clean up and adjustments.
@NoelStephensUnity
Merge branch 'develop-2.0.0' into fix/networktransport-early-and-post…
ec9b2fb 
…late-updates
@NoelStephensUnity
Update - Exp
1bd8559 
Experimenting with adjusting when transport adds inbound messages to the NGO inbound queue relative to when time is updated and NGO's inbound messages are processed.
@NoelStephensUnity
test + style
c964ea8 
adjusting transform ownership test slightly.
removing white space.
@NoelStephensUnity
test
b8d5d0e 
Tracking down the timing issue with this test.
@NoelStephensUnity
update
6471663 
Reverting back to both new connections and messages processing in EarlyUpdate and adding additional debug info to ownership test that keeps failing.
@NoelStephensUnity
update
cf21dc5 
Exposing the added early update and post late update methods so custom NetworkTransport implementations can take advantage of them.
Added additional xml API documentation for clarity.
@NoelStephensUnity
test
653b900 
I believe this will fix the issue with the DA failures in the ownership teats.
Updated UnityTransportTestHelpers to match recent adjustments.
@NoelStephensUnity
fix
7d5f7cd 
Fixing an issue with the base invocation.
@NoelStephensUnity
update
f826ba9 
Adding change log entries.
Found the culprit with the transform ownership instability. Moving an object can give it velocity which if there is enough time that passes between updates then fixed update will apply enough velocity motion to move the object and it will continue to move.
Increased mass and linearDampening and setting the linear velocity to zero in the appropriate places.
@NoelStephensUnity NoelStephensUnity merged commit 789f375 into develop-2.0.0 Nov 6, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networktransport-early-and-postlate-updates branch November 6, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-lemay-unity simon-lemay-unity simon-lemay-unity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @simon-lemay-unity