Skip to content

fix: prefab incontext or inIsolation edit mode globalobjectidhash incorrect when using MPPM #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Dec 9, 2024

This fixes the issue with the GlobalObjectIdHash value being incorrect when entering into play mode while still in prefab edit mode (InContext or InIsolation) and using MPPM.

MTTB-854

fix: #3151

Changelog

  • Fixed: Issue where the NetworkObjectIdHash value could be incorrect when entering play mode while still in prefab edit mode with pending changes and using MPPM.

Testing and Documentation

  • No tests have been added (requires manual testing).
  • No documentation changes or additions were necessary.

This fixes the issue with the GlobalObjectId value being incorrect when entering into play mode while still in prefab edit mode (InContext or InIsolation).
Minor fix to how we shutdown NetworkManager when exiting playmode to assure we follow the same steps as we do when the application quits.
InSceneObject needed to be checked for having a value before checking for the value.
Removed legacy methods used to detect when in edit mode.
Updated comments.
Adding changelog entry.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review December 9, 2024 22:21
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner December 9, 2024 22:21
@NoelStephensUnity NoelStephensUnity merged commit 5e38c31 into develop-2.0.0 Dec 10, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/prefab-incontext-or-insolation-edit-mode-globalobjectidhash branch December 10, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant