Skip to content

feat: session state token #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 7, 2025
Merged

feat: session state token #3228

merged 8 commits into from
Apr 7, 2025

Conversation

DSchroer
Copy link

@DSchroer DSchroer commented Feb 5, 2025

https://jira.unity3d.com/browse/MTT-10043

https://docs.google.com/document/d/1st5PoxRa7rg5JsLW0pKbVAgaqBP1QdUCx2gFlHXEicg/edit?tab=t.0

Adding a SessionStateToken to the ConnectionApproved message and incrementing the version. This is safe without implementing the feature as the service does not need to make any assumptions about what the client does with this information.

Changelog

  • Added: Session State Token into the ConnectionApproved message

Testing and Documentation

  • Tested using E2E tests and existing tests

Related PR

https://github.com/Unity-Technologies/mps-common-multiplayer-backend/pull/976

@DSchroer DSchroer requested a review from a team as a code owner February 5, 2025 18:18
@DSchroer DSchroer marked this pull request as draft February 5, 2025 21:15
Copy link
Collaborator

@EmandM EmandM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this SessionStateToken intended to be used outside of DistributedAuthority? If not, the token should go in the ServiceConfig rather than in the ConnectionApproval message itself

@DSchroer DSchroer marked this pull request as ready for review February 27, 2025 20:12
@DSchroer DSchroer requested a review from EmandM March 6, 2025 15:14
@EmandM EmandM enabled auto-merge (squash) April 7, 2025 16:59
@EmandM EmandM merged commit 53b94ca into develop-2.0.0 Apr 7, 2025
27 checks passed
@EmandM EmandM deleted the feat/session-state-token branch April 7, 2025 18:00
@michalChrobot
Copy link
Collaborator

Shouldn't we add this change to the CHANGELOG file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants