Skip to content

feat: Rework the DestroyObject path on the non-authority client #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EmandM
Copy link
Collaborator

@EmandM EmandM commented Feb 13, 2025

Rework the DestroyObjectMessage flow on the non-authority side. On the non-authority, ensure that InScenePlaced objects are never destroyed and that all other objects are always destroyed.

MTT-11307

Changelog

  • Fixed: On non-authority, never destroy the game object when it is InScenePlaced, otherwise always destroy

Testing and Documentation

  • Functionality covered by existing tests

@EmandM EmandM requested a review from a team as a code owner February 13, 2025 16:52
EmandM and others added 4 commits February 13, 2025 11:53
Adding warning if the NetworkObject does not exist since we should not be receiving a message to destroy a NetworkObject if it is either already destroyed =or= the local client is destroying objects when it should not be.
Changing Debug to NetworkLog
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made two minor adjustments to the PR, but other than that it looks good Emma!
:godmode:

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) February 14, 2025 21:29
@NoelStephensUnity NoelStephensUnity merged commit 711aa02 into develop-2.0.0 Feb 14, 2025
27 checks passed
@NoelStephensUnity NoelStephensUnity deleted the feat/mtt-11307-non-authority-destroy-object branch February 14, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants