Skip to content

fix: Incorrect clientId in OnClientConnectedCallback #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

fix: Incorrect clientId in OnClientConnectedCallback #3312

merged 2 commits into from
Feb 20, 2025

Conversation

EmandM
Copy link
Collaborator

@EmandM EmandM commented Feb 20, 2025

MTTB-1030

Fixes #3211

Changelog

  • Fixed: The clientId in the OnClientConnectedCallback was always 0 when scene management was disabled.

Testing and Documentation

  • Includes unit tests.
  • No documentation changes or additions were necessary.

@EmandM EmandM requested a review from a team as a code owner February 20, 2025 19:47
NoelStephensUnity
NoelStephensUnity approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
:electron:

@EmandM EmandM merged commit 9493824 into develop-2.0.0 Feb 20, 2025
27 checks passed
@EmandM EmandM deleted the fix/MTTB-1030-incorrect-clientid-in-callback branch February 20, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmandM @NoelStephensUnity