-
Notifications
You must be signed in to change notification settings - Fork 447
fix: distributed authority client synchronization issues #3350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NoelStephensUnity
merged 11 commits into
develop-2.0.0
from
fix/distributed-authority-client-synchronization-updates
Mar 25, 2025
Merged
fix: distributed authority client synchronization issues #3350
NoelStephensUnity
merged 11 commits into
develop-2.0.0
from
fix/distributed-authority-client-synchronization-updates
Mar 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nchronization-updates
EmandM
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks on the comments, but this looks good!
com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ClientConnectedMessage.cs
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ConnectionApprovedMessage.cs
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkSceneManager.cs
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkSceneManager.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkSceneManager.cs
Show resolved
Hide resolved
…ceneManager.cs Co-authored-by: Emma <[email protected]>
…nchronization-updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two client synchronization related issues:
NetworkManager.IsConnectedClient
not being set until after the client had finished synchronizing (i.e. all objects synchronized had run through the spawn process).fix: #3280
close: #3280
Changelog
Testing and Documentation
SpawnDuringSynchronizationTests
integration test.