Automate meta file check #2133
Merged
Automate meta file check #2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomaogy
reviewed
Jun 14, 2019
|
|
||
|
|
||
| def main(): | ||
| asset_path = "UnitySDK/Assets" |
There was a problem hiding this comment.
This assumes that you are always running in the root path of the repo, which I guess is fine since you will only run it in the circleci.
There was a problem hiding this comment.
Yeah, I guess we could add the path as a parameter if we need to later. But I think it's OK to leave hardcoded for now.
|
Overall looks good to me. The only things is that maybe we should not put this script inside the UnitySDK folder. This seems like a utils script and might worth its own folder? |
xiaomaogy
approved these changes
Jun 14, 2019
|
Sure, I'll look into moving it into a folder. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to automate part of our release checklist. This ensures each .meta file corresponds to a normal file, and each normal file has a .meta file (except for the script itself).
We could potentially run this as a unit test instead, but that would mean the mlagents package would have to read outside its own directory. Standalone script and executing in CI seemed like a cleaner approach.
Also, please check that my understanding of the checklist item is correct.