Skip to content

Fix inference CI timeouts in Match3 and VisualFoodCollector #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2021
Merged

Fix inference CI timeouts in Match3 and VisualFoodCollector #5298

merged 4 commits into from
Apr 21, 2021

Conversation

chriselion
Copy link
Contributor

Proposed change(s)

  • Previously, when in inference mode, Match3 would update a sub-step (find matches, remove them, drop, etc) every .25 seconds. In training, it would do all of these steps (until stable) every FixedUpdate. Now in inference, it does this every FixedUpdate if ModelOverrides are enabled.
  • Add ModelOverrides to Agents in VisualFoodCollector

Types of change(s)

  • CI

vincentpierre
vincentpierre approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I think we should cherry pick onto the release.

@chriselion chriselion merged commit 2fb3825 into main Apr 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the inference-timeouts branch April 21, 2021 17:37
chriselion pushed a commit that referenced this pull request Apr 21, 2021
Fix inference CI timeouts in Match3 and VisualFoodCollector (#5298)
cc92ec4 
* add ModelOverrider to VisualFoodCollector

* use fast stepping when graphics disabled

* match3 - check ModelOverrider instead of graphics

* comments
@chriselion chriselion mentioned this pull request Apr 21, 2021
Merged
1 task
chriselion pushed a commit that referenced this pull request Apr 21, 2021
Fix inference CI timeouts in Match3 and VisualFoodCollector (#5298) (#…
506ddd2 
…5302)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vincentpierre vincentpierre vincentpierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @vincentpierre