[MLA-1981] Don't allow connections to newer python trainers #5370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
May 14, 2021
| @@ -1 +1 @@ | |||
| m_EditorVersion: 2018.4.17f1 | |||
There was a problem hiding this comment.
This (and the manifest) were pretty old. Just affects Project, but it's annoying to keep excluding them.
chriselion
commented
May 14, 2021
| @@ -99,6 +100,41 @@ public RpcCommunicator(CommunicatorInitParameters communicatorInitParameters) | |||
| } | |||
|
|
|||
| internal static bool CheckPythonPackageVersionIsCompatible(string pythonLibraryVersion) | |||
There was a problem hiding this comment.
The diff is messy; the old code was renamed to CheckPythonPackageVersionIsSupported.
chriselion
commented
May 14, 2021
| PythonTrainerVersions.s_MinSupportedVersion, | ||
| PythonTrainerVersions.s_MaxSupportedVersion | ||
| ); | ||
| throw new UnityAgentsException("Incompatible trainer version."); |
There was a problem hiding this comment.
This gets caught and a different exception is thrown below.
chriselion
commented
May 14, 2021
|
|
||
| // Any version > to this is known to be incompatible and we will block training. | ||
| // Covers any patch to the release before the 2.0.0 package release. | ||
| internal static Version s_MaxCompatibleVersion = new Version("0.25.999"); |
There was a problem hiding this comment.
Just in case we do a 0.25.2 patch release.
surfnerd
approved these changes
May 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Version 0.26.0 (and higher) of the python trainers product files incompatible with the 1.0.x versions of the package. To prevent confusion and frustration, don't allow connections with these versions.
Note that the old logic for trainers that don't produce .nn files is still there with a warning; this is a separate hard error. I'm reluctant to make the old range a hard failure, since that would be a behavior change.
To summarize:
Also note that the old logic would warn on anything that wasn't in an X.Y.Z format (e.g. "1.2.3.dev4"). In this case, we try a little harder to extract the numerical part of the version (so that we can determine the version for clones of the github
mainbranch), but don't block if we can't parse (to prevent a potential behavior change).Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/MLA-1981
Types of change(s)
Checklist