Skip to content

Incremental boehm strict mode #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2018
Merged

Incremental boehm strict mode #1012

merged 2 commits into from
Aug 14, 2018

Conversation

jechter
Copy link

@jechter jechter commented Aug 14, 2018

  1. Add another write barrier needed for validation to pass
  2. Add a fix for running with gc disabled, which would deadlock in mono_gc_finalize_notify. This was already disabled for running with null gc, but not with running with a gc which is disabled (needed for write barrier validation).

@jechter jechter requested a review from joncham August 14, 2018 14:20
@jechter jechter merged commit def3444 into unity-master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncham joncham joncham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jechter @joncham