Fixing issue with debugger CREATE_BOXED_VALUE command. case 1169306. #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rider was sending a CMD_APPDOMAIN_CREATE_BOXED_VALUE command to the debugger agent when hovering over certain values in the debugger, which resulted in a class argument that was not a value type. The debugger tried to create an object of this type and unbox it, but asserted because it is not a value type. Catching this issue before the unbox command and returning an error prevents the Editor from crashing, but the debugger still cannot evaulate the value while hovering. However, the values can still be inspected using the locals window.
ghost
requested review from
ghost
self-assigned this
|
Do we need this in IL2CPP as well? |
joshpeterson
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rider was sending a CMD_APPDOMAIN_CREATE_BOXED_VALUE command to the
debugger agent when hovering over certain values in the debugger, which
resulted in a class argument that was not a value type. The debugger
tried to create an object of this type and unbox it, but asserted
because it is not a value type. Catching this issue before the unbox
call and returning an error prevents the Editor from crashing, but
the debugger still cannot evaluate the value while hovering. However,
the values can still be inspected using the locals window.