Skip to content

[Android] Fixing problem with toLanguageTag for API < 21 #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

BorisShir
Copy link

toLanguageTag is available only since API 21. For earlier devices (Android 4.4) getting locale will use get_posix_locale method which will return default value.
Proper workaround for Android 4.4 requires implementing quite complex code, and I don't see much sense in doing this.

@BorisShir BorisShir requested review from UnityAlex and hkr October 8, 2019 13:51
Copy link
Collaborator

@UnityAlex UnityAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me.

@BorisShir BorisShir merged commit c8a7ab0 into unity-master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants