Skip to content

Fix issue where get offset could return 0 when the type is uninited #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2018
Merged

Fix issue where get offset could return 0 when the type is uninited #999

merged 1 commit into from
Aug 13, 2018

Conversation

mderoy
Copy link

@mderoy mderoy commented Jul 24, 2018 •
edited
Loading

(Scripting Upgrade) Fix an issue where UnsafeUtility.GetFieldOffset could return 0 when the type is not initialized (case 1059122)

@mderoy mderoy self-assigned this Jul 24, 2018
@mderoy mderoy requested a review from joncham July 24, 2018 17:29
joncham
joncham approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@joncham joncham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to consider if this has any performance impact in Unity. My main worry is serialization logic.

@mderoy mderoy merged commit 2682b1e into unity-master Aug 13, 2018
@mderoy mderoy deleted the unity-master-fix-get-offset-initialization branch August 13, 2018 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpeterson joshpeterson joshpeterson approved these changes

@joncham joncham joncham approved these changes

Assignees

@mderoy mderoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mderoy @joshpeterson @joncham