Skip to content

Faceting: Fully implement FacetedPlot component #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 9 tasks
bobular opened this issue Nov 2, 2021 · 2 comments · Fixed by #252
Closed
4 of 9 tasks

Faceting: Fully implement FacetedPlot component #240

bobular opened this issue Nov 2, 2021 · 2 comments · Fixed by #252

Comments

@bobular
Copy link
Member

bobular commented Nov 2, 2021

Subtask to VEuPathDB/web-eda#635

Continues work on #162

  • decide on subplot size
  • make simple story for each plot type (PiePlot is done)
  • minimise margins within subplots (
  • minimise spacing between subplots (and get rid of temporary dotted outline)
  • render entire faceted plot in the drop-shadow border (not each plot)
  • fixed width and simple browser-based horizontal scroll bar
  • titles (showing facet.value) may need ellipsis support for long values

Optional for build 55

  • click-on-plot to an enlarged modal
  • "No data" facet styled differently (perhaps the title has a grey background)
@bobular bobular transferred this issue from VEuPathDB/web-eda Nov 2, 2021
@dmfalke dmfalke added this to the EDA ClinEpi Phase 2 milestone Nov 3, 2021
@dmfalke dmfalke changed the title Fully implement FacetedPlot component Faceting: Fully implement FacetedPlot component Nov 3, 2021
@dmfalke dmfalke mentioned this issue Nov 11, 2021
@dmfalke
Copy link
Member

dmfalke commented Nov 11, 2021

Most of this work is actually being done in web-eda. When we have some more time, we will move much of this work to web-components, as plot-specific variants of FacetedPlot.

@nkittur-uga
Copy link
Member

Faceted plots look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants