Skip to content

Faceting: individual FacetedPlot types #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
dmfalke opened this issue Nov 16, 2021 · 5 comments · Fixed by VEuPathDB/web-eda#771
Closed
3 tasks done

Faceting: individual FacetedPlot types #259

dmfalke opened this issue Nov 16, 2021 · 5 comments · Fixed by VEuPathDB/web-eda#771
Assignees
Labels
b56 enhancement New feature or request high cost

Comments

@dmfalke
Copy link
Member

dmfalke commented Nov 16, 2021

This is a follow-up to #240, which lists tasks for FacetedPlot.

  • make FacetedPlot components for each plot type (e.g., FacetedBarPlot)
  • make simple story for each plot type (PiePlot is done)
  • click-on-plot to an enlarged modal
    "No data" facet styled differently (perhaps the title has a grey background) Fixed in Faceting title and empty data #262
@dmfalke dmfalke added this to the EDA ClinEpi Phase 2 milestone Nov 16, 2021
@danicahelb danicahelb added b55 enhancement New feature or request b56 labels Nov 17, 2021
@bobular bobular removed the b55 label Nov 17, 2021
@chowington
Copy link
Member

Striking out the third task above because it was done in #262

@chowington chowington self-assigned this Nov 22, 2021
@dmfalke
Copy link
Member Author

dmfalke commented Nov 23, 2021

@chowington I must have authored this issue in haste. It is missing a crucial component, which is to make a FacetedPlot component for each of the plot types we provide. Ideally, they should use styling similar to what we are doing in visualizations in web-eda. I will update the description to reflect this. Sorry for the confusion. The stories do look great!

@dmfalke dmfalke changed the title Faceting: Faceting: individual FacetedPlot types Nov 23, 2021
@chowington
Copy link
Member

chowington commented Nov 24, 2021

@dmfalke I started work on the individual plot components but I don't have a great idea of how to integrate them into our existing structure, particularly with FacetedPlot. I just worked on the FacetedBarplot as a test run and pushed it to a different branch than the one that has a PR linked to this ticket: https://github.com/VEuPathDB/web-components/tree/individual-facetedplot-components. It's not currently functional, but you can see what I'm attempting to do. Let me know what your thoughts are.

@chowington
Copy link
Member

Bumping up to high cost due to extra core-components modal work for good housekeeping

@nkittur-uga
Copy link
Member

Dave advised that the primary ux change is the ability to click on a facet to see an enlarged plot. I tested this and it works. Passes QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b56 enhancement New feature or request high cost
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants