UpSet preparations #168
Draft
UpSet preparations #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch just sets the scene for implementing our UpSet plot component around the UpSetJS library.
The package has been added from npm (
yarn add @upsetjs/react) and the component (plots/UpSet.tsx) and data definition (types/plots/upset.ts) and story (UpSet.stories.tsx) have been created - very barebones!A few things to note:
extractFromExpression) and pass it to the UpSetJS component. It's fine to change the UpSetData definition however you please.Actually I think that's all. We should probably not merge this into main, but if we are happy to go ahead with UpSetJS, then make a branch off this branch and call it
upsetand close this Draft PR.