You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that faceting Mosaic plots on Country (where country is filtered in subsetting to just one country) looks like a no-op (there's only one facet, so the facet layout handling is not triggered). There should be mostly empty plots.
Should coordinate with @chowington who is working on #681 - we discussed how to deal with it here but I think we concluded the opposite to what we wrote down 😬
The plot components already test for "empty data" (usually data.series.length === 0) and render a skeleton. However, the individual components all use 'empty data' as a fallback value for the data prop. Example here.
We were going to make the plot component (probably at PlotlyPlot.tsx) render its own HTML title and render a no-data message instead of the skeleton plot. We may need to change the fallback handling of data as described above. I think these changes would be too much for a last minute b55 push.
I'll keep thinking about how best to do this in discussion with @chowington
The text was updated successfully, but these errors were encountered:
I think a low cost approach would be to make a "delegate component" in web-eda. This component would be responsible for either rendering the "no data" UI if data is undefined, or delegating to the actual plot component. The props interface would look very similar to FacetedPlot. I'll leave the implementation details as homework, but happy to provide more if needed!
I think a low cost approach would be to make a "delegate component" in web-eda. This component would be responsible for either rendering the "no data" UI if data is undefined, or delegating to the actual plot component. The props interface would look very similar to FacetedPlot. I'll leave the implementation details as homework, but happy to provide more if needed!
Oh, sorry, just saw this. I think we're going with Connor's solution that is triggered in FacetedPlot by undefined data.
I noticed that faceting Mosaic plots on Country (where country is filtered in subsetting to just one country) looks like a no-op (there's only one facet, so the facet layout handling is not triggered). There should be mostly empty plots.
Should coordinate with @chowington who is working on #681 - we discussed how to deal with it here but I think we concluded the opposite to what we wrote down 😬
The plot components already test for "empty data" (usually
data.series.length === 0
) and render a skeleton. However, the individual components all use 'empty data' as a fallback value for thedata
prop. Example here.We were going to make the plot component (probably at PlotlyPlot.tsx) render its own HTML title and render a no-data message instead of the skeleton plot. We may need to change the fallback handling of
data
as described above. I think these changes would be too much for a last minute b55 push.I'll keep thinking about how best to do this in discussion with @chowington
The text was updated successfully, but these errors were encountered: