Skip to content

Visualizations: VariableCoverageTable can take a filteredCounts prop instead of filters #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobular opened this issue Dec 6, 2021 · 0 comments · Fixed by #770
Closed

Visualizations: VariableCoverageTable can take a filteredCounts prop instead of filters #752

bobular opened this issue Dec 6, 2021 · 0 comments · Fixed by #770
Assignees
@bobular
Labels
technical debt
Milestone
EDA ClinEpi Phase 2

Comments

@bobular
Copy link
Member

bobular commented Dec 6, 2021 •
edited
Loading

At the moment (correct me if I'm wrong) the VariableCoverageTable component takes a filters prop and uses useEntityCounts(filters) to fetch the filtered counts. We should be able to pass filteredCounts in directly from the calling viz components. Should save some back end calls too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobular bobular

Labels
technical debt
Projects
None yet
Milestone
EDA ClinEpi Phase 2
Development

Successfully merging a pull request may close this issue.

More sophisticated showMissing behaviour and reused more entity counts VEuPathDB/web-eda
1 participant
@bobular