-
Notifications
You must be signed in to change notification settings - Fork 0
More sophisticated showMissing behaviour and reused more entity counts #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ready for review please. Seems to work fine with latest merge from main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into the skeleton issue a little more and couldn't find a solution in the short time I spent on it. Let's go with this for now and revisit. I suspect the solution will involve ensuring filters
and EntityCounts
props that are passed to visualizations are consistent. It's late and I don't see an obvious way to do this, but I'm confident there is a solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested a couple of cases and they looked fine 👍
Thanks both for reviewing. I've added a ticket for the skeleton issue. Please change if you don't think it's |
Resolves #676
Resolves #752
No data issue are fixed for all visualizations (mosaic doesn't need it because only one stratification var), as well as the rationalisation of the back end entity count calls.
There is one remaining UX niggle, which will need some discussion and a future ticket: when viewing a faceted plot, cancelling a subsetting filter via the global filters popup changes the layout of the "skeleton spinners" to single un-faceted layout. When the data comes from the back end, the layout reverts again to faceted. This is to do with waiting for
facetedCounts
to no longer be pending.