Skip to content

Visualizations: edge case skeleton spinner faceted/unfaceted layout issue #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobular opened this issue Dec 10, 2021 · 0 comments
Open
Labels
bug Something isn't working low cost low priority

Comments

@bobular
Copy link
Member

bobular commented Dec 10, 2021

To reproduce:
Any study. Add one or more subsetting filters.
Make any visualization, add a facet variable.
Now note that any variable changes you make while faceting is active, the layout stays in faceting mode and the page update looks relatively smooth.

However, if you open the global filters popup and cancel a filter you made, you'll notice the layout switch back to unfaceted, before switching to faceted again.

This is because the visualisations are waiting for filteredCounts.pending to be untrue - this data is needed to decide on showing missing data overlays and facets - and when pending is true, data becomes undefined and then the plot components don't know how to lay themselves out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low cost low priority
Projects
None yet
Development

No branches or pull requests

1 participant