Add MarkCommand to handle mark creation in command line #9483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Fields
requested changes
May 22, 2025
J-Fields
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR implements the
markEx command which allows users to set marks. While themkey also achieves this goal, implementing it as an ex command (1) is a missing feature for which PRs were invited and (2) allows other VSCode extensions to create marks by callingvim.remapwith the appropriatecommandsargument. I have a separate use-case where I'd like to make sure a position is added to the jumplist (i.e. do:mark ').Which issue(s) this PR fixes: N/A
Special notes for your reviewer: This is my first PR to the vscode vim extension, so I'd appreciate any input on how to contribute better. I'm a long time user and fan, so super excited to be submitting a PR!
Also, in full disclosure, this PR was partially written with AI using AugmentCode.